[coreboot-gerrit] [M] Change in coreboot[master]: mb/google/link: rework TP/TS ACPI to add support for new Windows I2C ...

[Felix Singer (Code Review)]

Attention is currently required from: CoolStar, Martin Roth, Matt DeVillier, Stefan Reinauer.

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76159?usp=email )

Change subject: mb/google/link: rework TP/TS ACPI to add support for new Windows I2C driver
......................................................................

Patch Set 4:

(1 comment)

File src/mainboard/google/link/acpi/mainboard.asl:

https://review.coreboot.org/c/coreboot/+/76159/comment/5e4a5ccd_783aaff7 :
PS1, Line 14: // Trackpad Wake is GPIO12
            : 		Name(_PRW, Package() { BOARD_TRACKPAD_WAKE_GPIO, 0x03 } )
            :
> what do ppl think about commenting out and adding a note as to why vs removing?

I don't know if it's worth it, but how about using a Kconfig option to decide which code should be used? So we could guard these lines with `#ifndef CONFIG_WINDOWS_HACK` and Windows users can choose. Just an idea :)