Attention is currently required from: Arthur Heymans, Ashish Kumar Mishra, Saurabh Mishra, Subrata Banik.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82079?usp=email )
Change subject: block/fast_spi: Use read32p/write32p for spi rw
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82079/comment/c3033f71_8ec44b19 :
PS2, Line 7: spi
SPI
https://review.coreboot.org/c/coreboot/+/82079/comment/20848c33_104dc6a8 :
PS2, Line 9: impl.
No need to abbreviate words in the commit message.
https://review.coreboot.org/c/coreboot/+/82079/comment/ea6a0127_06559644 :
PS2, Line 15: TEST=Build and boot mtl 64-bit and verified MRC cache working.
Any boot time difference?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82079?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I317c7160bf192dd2aeacebf6029a809bc97f3420
Gerrit-Change-Number: 82079
Gerrit-PatchSet: 2
Gerrit-Owner: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-Reviewer: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-Attention: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 24 Apr 2024 13:28:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment