[coreboot-gerrit] [XL] Change in coreboot[main]: soc/intel/ptl: Do initial Panther Lake SoC commit till ramstage

[Subrata Banik (Code Review)]

Attention is currently required from: Cliff Huang, Saurabh Mishra.

Subrata Banik has posted comments on this change by Saurabh Mishra. ( https://review.coreboot.org/c/coreboot/+/83798?usp=email )

Change subject: soc/intel/ptl: Do initial Panther Lake SoC commit till ramstage
......................................................................

Patch Set 17:

(1 comment)

File src/soc/intel/pantherlake/Kconfig:

https://review.coreboot.org/c/coreboot/+/83798/comment/b2f58497_3af5be2e?usp... :
PS17, Line 336: config FSP_FD_PATH
> Adding it back, to keep the recipe buildable. Seeing build issue w/o this config in standalone env.

I don't understand why you've encountered a compilation issue. Ideally, this configuration depends on FSP_USE_REPO, and I don't see that PTL SoC ever selects that configuration. Therefore, FSP_FD_PATH is just a stale path. Please avoid adding code before its time. It only makes sense to add this Kconfig after Intel releases the FSP.fd in external GitHub. If you want to use a standalone build, be sure to override it from the .config file, not from the PTL Kconfig.