Attention is currently required from: Himanshu Sahdev, Julius Werner, Lean Sheng Tan, Rizwan Qureshi, Subrata Banik, Tarun Tuli, Wonkyu Kim.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75357?usp=email )
Change subject: cpu/intel/microcode: Have CPU microcode per CPUID into CBFS ......................................................................
Patch Set 18:
(1 comment)
File src/cpu/Kconfig:
https://review.coreboot.org/c/coreboot/+/75357/comment/46b4c9e9_681d1c3e : PS14, Line 123: bool "Include microcode per CPUID into CBFS"
> This option will show on ALL platforms. Does it even make sense to have it as a user visible option?
it will allow to override the default value from site-local rather forcing to enable from SoC/MB config using upstream coreboot.
As we are not uploading the ucode blobs in coreboot upstream build hence it's easy to go by default value which is `n` and don't need to specify the split ucode blob path.
@Arthur, ping! can you please take a relook.
marking this resolved for now after keeping open for 1 week
It's not about default values. If I run make menuconfig and select a mainboard I should not be able to see any option that makes no sense.
Which is the case now. I can see the option to split microcode on platforms that would not boot when selecting it as they rely on concatenation. Also I would see the existing options to include microcode and this new method. This should be mutually exclusive.
do you suggest to use a HAVE_ config to ensure this user visible prompt is only visible for the desired platform and not to others ?
Would it make sense to have " choice prompt "Include CPU microcode in CBFS" if ARCH_X86 " depends on !CPU_INTEL_MICROCODE_CBFS_SPLIT_BINS ?