Attention is currently required from: Paz Zcharya, Terry Chen, Tim Wawrzynczak, Nick Vaccaro, Franklin Lin, Rajat Jain.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68868 )
Change subject: mb/google/brya: Update Crota's ELAN touchscreen delay to 150 ms
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/google/brya/variants/crota/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/68868/comment/8b76812b_d442fcbb
PS6, Line 225: 150
This delay is "parallelized" with other initializatoin operations, and since they are in seconds, this delay does not matter. (Even if we had 0 delay, ther delays in other drivers take care of it at boot time). But then we introduce this unstated dependency on other drivers taking > x ms. That is problem 1.
Other problem is that at resume time, things go a lot faster (our resume time expectation is within 500ms). There also we parallelize this delay, but we'd like to have a way to ensure what is the minimum delay before which the touschscreen can become funtional.
lets continue this discussion over a bug?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68868
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I17e1f7d419637f6dff4049484ce1836ad98017ea
Gerrit-Change-Number: 68868
Gerrit-PatchSet: 6
Gerrit-Owner: Paz Zcharya
pazz@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Franklin Lin
franklin_lin@wistron.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Rajat Jain
rajatja@google.com
Gerrit-Attention: Paz Zcharya
pazz@google.com
Gerrit-Attention: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Franklin Lin
franklin_lin@wistron.corp-partner.google.com
Gerrit-Attention: Rajat Jain
rajatja@google.com
Gerrit-Comment-Date: Wed, 26 Oct 2022 18:07:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paz Zcharya
pazz@google.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Rajat Jain
rajatja@google.com
Gerrit-MessageType: comment