Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42830 )
Change subject: soc/amd/picasso: Add console & timestamp buffers to psp_verstage ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42830/3/src/soc/amd/picasso/memlayo... File src/soc/amd/picasso/memlayout_psp_verstage.ld:
https://review.coreboot.org/c/coreboot/+/42830/3/src/soc/amd/picasso/memlayo... PS3, Line 57: vboot2_work
Do the console and timestamp regions have some kind of magic value we can use in bootblock to check […]
I'm not sure. I'll take a look, but even if there isn't we can add something. That'll be in a later patch when we actually start using the regions though.
https://review.coreboot.org/c/coreboot/+/42830/3/src/soc/amd/picasso/psp_ver... File src/soc/amd/picasso/psp_verstage/psp_verstage.c:
https://review.coreboot.org/c/coreboot/+/42830/3/src/soc/amd/picasso/psp_ver... PS3, Line 155: _vboot2_work
Can you define a new region in the linker script: _workbuf and _eworkbuf. […]
how about _transfer_buf? naming it _workbuf but including things in it that aren't the workbuf are going to make it even more confusing. _vboot2_work *IS* just the workbuf, but it's the start of the whole transfer buffer.