HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42201 )
Change subject: soc/intel/skylake: Check Kconfig symbols in C instead of preprocessor ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42201/3/src/soc/intel/skylake/acpi.... File src/soc/intel/skylake/acpi.c:
https://review.coreboot.org/c/coreboot/+/42201/3/src/soc/intel/skylake/acpi.... PS3, Line 1: please, why this new line?
https://review.coreboot.org/c/coreboot/+/42201/3/src/soc/intel/skylake/acpi.... PS3, Line 179: else { please why this new 'else' ? it is not needed