Attention is currently required from: Reka Norman, Eric Lai.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62722 )
Change subject: mb/google/nissa/var/nivviks: Add GL9750 power sequence
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/brya/variants/nivviks/gpio.c:
https://review.coreboot.org/c/coreboot/+/62722/comment/83802413_88d38a62
PS1, Line 56: PAD_CFG_GPO(GPP_H12, 1, DEEP)
If it works in ramstage too, it seems simpler to just do it there. […]
If you check brya variants again, you will see several of them have moved deassertoin of PERST_L for storage devices to romstage GPIO table. There appears to be some timing change in ADL FSP where it is scanning PCIe RPs for downstream devices earlier than prior FSPs.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62722
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib6d461a56f6aeba30994daafe8993c36df4b309d
Gerrit-Change-Number: 62722
Gerrit-PatchSet: 1
Gerrit-Owner: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Thu, 10 Mar 2022 03:04:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Reka Norman
rekanorman@chromium.org
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment