CK HU has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43960 )
Change subject: soc/mediatek/mt8192: Add spi driver
......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43960/1/src/soc/mediatek/mt8192/inc...
File src/soc/mediatek/mt8192/include/soc/spi.h:
https://review.coreboot.org/c/coreboot/+/43960/1/src/soc/mediatek/mt8192/inc...
PS1, Line 42:
This hasn't been addressed yet. Please remove the extra blank line.
Done
https://review.coreboot.org/c/coreboot/+/43960/1/src/soc/mediatek/mt8192/spi...
File src/soc/mediatek/mt8192/spi.c:
https://review.coreboot.org/c/coreboot/+/43960/1/src/soc/mediatek/mt8192/spi...
PS1, Line 111: pad_select == SPI_PAD0_MASK
Please change it.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43960
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2094dd2f14ad19b7dbd66a8e694cc71d654a2b4b
Gerrit-Change-Number: 43960
Gerrit-PatchSet: 6
Gerrit-Owner: CK HU
ck.hu@mediatek.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: wang qii
Qii.Wang@mediatek.com
Gerrit-Comment-Date: Tue, 11 Aug 2020 05:41:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: wang qii
Qii.Wang@mediatek.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment