Shelley Chen has submitted this change. ( https://review.coreboot.org/c/coreboot/+/68571 )
Change subject: mb/google/herobrine: Remove NVMe from device tree ......................................................................
mb/google/herobrine: Remove NVMe from device tree
We need to boot eMMC for modem calibration, there is not need for BIOS to initialize NVMe anymore as the kernel will do so. Removing the pci device from the device tree as a first step.
BUG=b:185426670, b:254281839 BRANCH=None TEST=Boot after removing from the herobrine device tree.
Change-Id: I802dd1361bc56a24ab3d65e6782bc611b7b75ee3 Signed-off-by: Shelley Chen shchen@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/68571 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Julius Werner jwerner@chromium.org --- M src/mainboard/google/herobrine/devicetree.cb 1 file changed, 21 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved
diff --git a/src/mainboard/google/herobrine/devicetree.cb b/src/mainboard/google/herobrine/devicetree.cb index 34360b7..e23782f 100644 --- a/src/mainboard/google/herobrine/devicetree.cb +++ b/src/mainboard/google/herobrine/devicetree.cb @@ -2,7 +2,4 @@
chip soc/qualcomm/sc7280 device cpu_cluster 0 on end - device domain 0 on - device pci 00.0 on end - end end