Roy Mingi Park has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40006 )
Change subject: mb/google/ripto: Enable DMI/SATA power Optimizer
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/40006/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/40006/1//COMMIT_MSG@10
PS1, Line 10:
Ack
With those flags, SATA controller can go to low power state such as Dev Sleep. Upon entering Device Sleep, the Host and device may power down PLL's, clocks, and media in addition to the PHY interface. And
average SATA power will be ~5mW.
Without those flags, SATA power will be higher than 10mW as it can't go to Dev Sleep.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40006
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I179d83c3c75468ece263ccb3cde9f620ecb858cd
Gerrit-Change-Number: 40006
Gerrit-PatchSet: 4
Gerrit-Owner: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Roy Mingi Park
roy.mingi.park@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 17 Apr 2020 23:38:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Shaunak Saha
shaunak.saha@intel.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment