Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32017 )
Change subject: mb/google/hatch: Enable FP MCU ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/32017/2/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/#/c/32017/2/src/mainboard/google/hatch/variants/... PS2, Line 299: chip drivers/spi/acpi
I am not sure tbh. We did not do this for nami. […]
Actually, there is nothing in the kernel that actually uses it. So, currently we don't need to export reset gpio.
https://review.coreboot.org/#/c/32017/2/src/mainboard/google/hatch/variants/... PS2, Line 305: GPE0_DW0_23 Doesn't this cause failures to enter S0ix since GPP_A23 is not configured with INVERT?