Attention is currently required from: Martin L Roth, Angel Pons, Martin Roth.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68545 )
Change subject: console: Add a 32-bit vendor post-code call ......................................................................
Patch Set 1:
(1 comment)
File src/console/post.c:
https://review.coreboot.org/c/coreboot/+/68545/comment/7214359f_def6ffb6 PS1, Line 22: uint32_t
One of those patches comes immediately after this, and more are coming.
Do you mean CB:68546? Because I don't see it...
I guess my question is what exactly you want this function to be. Because right now it just looks like a hook which platforms can implement so they can run code whenever something calls post_code(). For that purpose, making this 32-bit is pointless as long as post_code() is 8-bit.
Sounds like you also want it to be something else, but in that case that's not readily apparent to me from this patch series. Are you saying that some code would want to log 32-bit post codes by calling soc_post_code() directly? Would that be an AMD-specific feature or also supposed to be generic?
I'm asking these questions because I feel that in that case it may make more sense to design this slightly differently (e.g. maybe change post_code() to take 32-bits and then have all the implementations throw codes away that are higher than what they can support), but since I'm not really sure what you're trying to do it's hard to say.