Attention is currently required from: David Wu, Zhuohao Lee, Alan Huang.
Hou-hsun Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59576 )
Change subject: mb/google/brya/var/brask: Set PL and PsysPL
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/brya/variants/brask/ramstage.c:
https://review.coreboot.org/c/coreboot/+/59576/comment/dfe91092_67d2e39d
PS2, Line 41: 13.52A
This looks weird to me. The max current of the typec is 5A. […]
The Psys_pmax is just a SW setting which tells IMVP9.1 the mapping b/w system input current and the actual system power (There is no voltage info for IMVP9.1).
Imagine that there is a type-c 100W (20V/5A) connected to DUT w/ full loading, and the Psys_pmax setting is 270.4W.
Then IMVP9.1 can calculate the current system power = 270.4W * 5A / 13.52A = 100W, which is the actual system power.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59576
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9261902b8c892d0b866f326b24988039c1d30b56
Gerrit-Change-Number: 59576
Gerrit-PatchSet: 2
Gerrit-Owner: Alan Huang
alan-huang@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Hou-hsun Lee
hou-hsun.lee@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: Alan Huang
alan-huang@quanta.corp-partner.google.com
Gerrit-Comment-Date: Mon, 29 Nov 2021 04:10:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Zhuohao Lee
zhuohao@google.com
Gerrit-MessageType: comment