Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33823 )
Change subject: src: Use standard <inttypes.h>
......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33823/11/src/include/inttypes.h
File src/include/inttypes.h:
https://review.coreboot.org/c/coreboot/+/33823/11/src/include/inttypes.h@71
PS11, Line 71: #define PRIiFAST8 "i" /* int_fast8_t */
I don't think the standard requires "i" for PRIi16? At least I'm not seeing it. […]
I don't see a requirement. Simply, `h` for PRIi16 and `hh` for PRIi8 would
be no-ops by definition. If we'd put them here, it would be less confusing
for those that don't know about the integer promotions and more confusing
for those that do know. Nobody can win, I guess.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33823
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9e3a300f9b1c38e4831b030ff8af3fed2fa60f14
Gerrit-Change-Number: 33823
Gerrit-PatchSet: 11
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 10 Jul 2019 20:06:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment