Attention is currently required from: Raul Rangel, Karthik Ramasubramanian, Mark Hasemeyer.
Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74105 )
Change subject: mb/google/myst: Enable USB controllers
......................................................................
Patch Set 25:
(1 comment)
File src/mainboard/google/myst/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/74105/comment/24298a57_6b5ca2ca
PS25, Line 14: device ref xhci_1 on end
Also this gpp_bridge_a device should go under domain 0 as pointed out in the previous CL.
It's done and I addressed the domain issue in the previous CL. I've been holding off on updating the patch train once a day so I don't overwhelm the builders upstream.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74105
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I05dc5bb157f0ef955e4b37e34d7b32678e42ebc8
Gerrit-Change-Number: 74105
Gerrit-PatchSet: 25
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Mark Hasemeyer
markhas@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Mark Hasemeyer
markhas@google.com
Gerrit-Comment-Date: Tue, 11 Apr 2023 16:25:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jon Murphy
jpmurphy@google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment