[coreboot-gerrit] [L] Change in coreboot[main]: soc/mediatek/mt8196: Add PMIC MT6363 driver

[Yu-Ping Wu (Code Review)]

Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin.

Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85127?usp=email )

Change subject: soc/mediatek/mt8196: Add PMIC MT6363 driver
......................................................................

Patch Set 17:

(2 comments)

File src/soc/mediatek/common/include/soc/mt6363.h:

https://review.coreboot.org/c/coreboot/+/85127/comment/e175121d_ba56973e?usp... :
PS17, Line 111: void mt6363_write_field(u32 reg, u32 val, u32 mask, u32 shift);
Move after write8.

File src/soc/mediatek/common/mt6363.c:

https://review.coreboot.org/c/coreboot/+/85127/comment/dafe30f3_315135bd?usp... :
PS17, Line 38: reg_val
data