Attention is currently required from: Jérémy Compostella, Pranava Y N, Subrata Banik.
Hello Jérémy Compostella, Pranava Y N, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/85464?usp=email
to look at the new patch set (#4).
Change subject: mb/google/fatcat: config GPP_F23 as ISH gpio pin ......................................................................
mb/google/fatcat: config GPP_F23 as ISH gpio pin
The GPP_F23/ISH_GP_9A pin receives the lid open/close signal from SMC_LID. This pin is not utilized in the AP firmware stack; however, the ISH firmware requires this signal for its tablet mode support. Therefore, we configure this pin as an ISH GPIO.
BUG=b:370984186 TEST=Build and flash CB; run ISH main firmware; read this pin and verified it returned the correct value.
fatcat-rev257 ~ # ectool --name=cros_ish gpioget lid_open GPIO lid_open = 1
Change-Id: I19a4d6967acf96aefe2f38d628f898811d8a6e6d Signed-off-by: Li Feng li1.feng@intel.com --- M src/mainboard/google/fatcat/variants/fatcat/gpio.c 1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/85464/4