Attention is currently required from: Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik.
SH Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80326?usp=email )
Change subject: mb/google/brya/var/xol: Update memory configuration ......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/brya/variants/xol/memory/mem_parts_used.txt:
https://review.coreboot.org/c/coreboot/+/80326/comment/a00fd9c6_2b2c8fb5 : PS2, Line 1: # This is a CSV file containing a list of memory parts used by this variant. : # One part per line with an optional fixed ID in column 2. : # Only include a fixed ID if it is required for legacy reasons! : # Generated IDs are dependent on the order of parts in this file, : # so new parts must always be added at the end of the file! : # : # Generate an updated Makefile.inc and dram_id.generated.txt by running the : # part_id_gen tool from util/spd_tools. : # See util/spd_tools/README.md for more details and instructions.
should we keep these auto generated lines ?
Done