Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60553 )
Change subject: soc/intel: Remove unused <string.h> ......................................................................
soc/intel: Remove unused <string.h>
Found using following command: diff <(git grep -l '#include <string.h>' -- src/) <(git grep -l 'STRINGIFY|memcpy(|memmove(|memset(|memcmp(|memchr(|strdup(|strconcat(|strnlen(|strlen(|strchr(|strncpy(|strcpy(|strcmp(|strncmp(|strspn(|strcspn(|strstr(|strtok_r(|strtok(|atol(|strrchr(|skip_atoi(|vsnprintf(|snprintf(' -- src/)
Change-Id: Iae90ff482f534d8de2a519619c20a019d054e700 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/60553 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/soc/intel/alderlake/acpi.c M src/soc/intel/cannonlake/acpi.c M src/soc/intel/common/block/irq/irq.c M src/soc/intel/elkhartlake/acpi.c M src/soc/intel/elkhartlake/fsp_params.c M src/soc/intel/elkhartlake/romstage/fsp_params.c M src/soc/intel/icelake/acpi.c M src/soc/intel/jasperlake/acpi.c M src/soc/intel/jasperlake/romstage/fsp_params.c M src/soc/intel/tigerlake/acpi.c 10 files changed, 0 insertions(+), 10 deletions(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/soc/intel/alderlake/acpi.c b/src/soc/intel/alderlake/acpi.c index ab25646..1595534 100644 --- a/src/soc/intel/alderlake/acpi.c +++ b/src/soc/intel/alderlake/acpi.c @@ -18,7 +18,6 @@ #include <soc/pm.h> #include <soc/soc_chip.h> #include <soc/systemagent.h> -#include <string.h> #include <types.h>
/* diff --git a/src/soc/intel/cannonlake/acpi.c b/src/soc/intel/cannonlake/acpi.c index fa84ea8..d5a0a17 100644 --- a/src/soc/intel/cannonlake/acpi.c +++ b/src/soc/intel/cannonlake/acpi.c @@ -17,7 +17,6 @@ #include <soc/pci_devs.h> #include <soc/pm.h> #include <soc/systemagent.h> -#include <string.h>
#include "chip.h"
diff --git a/src/soc/intel/common/block/irq/irq.c b/src/soc/intel/common/block/irq/irq.c index c913c5a..0074451 100644 --- a/src/soc/intel/common/block/irq/irq.c +++ b/src/soc/intel/common/block/irq/irq.c @@ -11,7 +11,6 @@ #include <soc/pci_devs.h> #include <southbridge/intel/common/acpi_pirq_gen.h> #include <stdlib.h> -#include <string.h> #include <types.h>
#define MIN_SHARED_IRQ 16 diff --git a/src/soc/intel/elkhartlake/acpi.c b/src/soc/intel/elkhartlake/acpi.c index 44387ea..59a9adb 100644 --- a/src/soc/intel/elkhartlake/acpi.c +++ b/src/soc/intel/elkhartlake/acpi.c @@ -18,7 +18,6 @@ #include <soc/pm.h> #include <soc/soc_chip.h> #include <soc/systemagent.h> -#include <string.h>
/* * List of supported C-states in this processor. diff --git a/src/soc/intel/elkhartlake/fsp_params.c b/src/soc/intel/elkhartlake/fsp_params.c index f30bb1e..ff7222d 100644 --- a/src/soc/intel/elkhartlake/fsp_params.c +++ b/src/soc/intel/elkhartlake/fsp_params.c @@ -14,7 +14,6 @@ #include <soc/pci_devs.h> #include <soc/ramstage.h> #include <soc/soc_chip.h> -#include <string.h> #include <types.h>
/* SATA DEVSLP idle timeout default values */ diff --git a/src/soc/intel/elkhartlake/romstage/fsp_params.c b/src/soc/intel/elkhartlake/romstage/fsp_params.c index ecb6304..402b134 100644 --- a/src/soc/intel/elkhartlake/romstage/fsp_params.c +++ b/src/soc/intel/elkhartlake/romstage/fsp_params.c @@ -9,7 +9,6 @@ #include <soc/pci_devs.h> #include <soc/romstage.h> #include <soc/soc_chip.h> -#include <string.h>
static void soc_memory_init_params(FSP_M_CONFIG *m_cfg, const struct soc_intel_elkhartlake_config *config) diff --git a/src/soc/intel/icelake/acpi.c b/src/soc/intel/icelake/acpi.c index d11f3ca..26c5aba 100644 --- a/src/soc/intel/icelake/acpi.c +++ b/src/soc/intel/icelake/acpi.c @@ -15,7 +15,6 @@ #include <soc/pm.h> #include <soc/soc_chip.h> #include <soc/systemagent.h> -#include <string.h>
/* * List of supported C-states in this processor. diff --git a/src/soc/intel/jasperlake/acpi.c b/src/soc/intel/jasperlake/acpi.c index ad6a79c..a877e1a 100644 --- a/src/soc/intel/jasperlake/acpi.c +++ b/src/soc/intel/jasperlake/acpi.c @@ -18,7 +18,6 @@ #include <soc/pm.h> #include <soc/soc_chip.h> #include <soc/systemagent.h> -#include <string.h>
/* * List of supported C-states in this processor. diff --git a/src/soc/intel/jasperlake/romstage/fsp_params.c b/src/soc/intel/jasperlake/romstage/fsp_params.c index fd59e4e..43a8c70 100644 --- a/src/soc/intel/jasperlake/romstage/fsp_params.c +++ b/src/soc/intel/jasperlake/romstage/fsp_params.c @@ -9,7 +9,6 @@ #include <soc/pci_devs.h> #include <soc/romstage.h> #include <soc/soc_chip.h> -#include <string.h>
static void soc_memory_init_params(FSP_M_CONFIG *m_cfg, const struct soc_intel_jasperlake_config *config) diff --git a/src/soc/intel/tigerlake/acpi.c b/src/soc/intel/tigerlake/acpi.c index 36fb679..6314d1c 100644 --- a/src/soc/intel/tigerlake/acpi.c +++ b/src/soc/intel/tigerlake/acpi.c @@ -18,7 +18,6 @@ #include <soc/pm.h> #include <soc/soc_chip.h> #include <soc/systemagent.h> -#include <string.h>
/* * List of supported C-states in this processor.
4 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one.