Attention is currently required from: Subrata Banik, Tim Wawrzynczak.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62914 )
Change subject: soc/intel/alderlake: Add UfsEnable parameter
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/alderlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/62914/comment/92aee1b5_d3cafaeb
PS1, Line 620: s_cfg->UfsEnable[0] = is_devfn_enabled(PCH_DEVFN_UFS);
This is very weird, as per EDS, ADL-N supports only 1 UFS controller but FSP code assumes/kept place […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62914
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic9b956204fb1001977d86c0d898b2734efb32271
Gerrit-Change-Number: 62914
Gerrit-PatchSet: 2
Gerrit-Owner: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Fri, 18 Mar 2022 05:49:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment