Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45742 )
Change subject: mainboard/volteer: enable early tcss chrome ec related code in mainboard
......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45742/8/src/mainboard/google/voltee...
File src/mainboard/google/volteer/Kconfig:
PS8:
I believe this also requires RUN_FSP_GOP, which we do actually define, but we have it in our config.volteer file which gets merged with this config in our build system. I think we'll have to move that config option here so this will compile.
https://review.coreboot.org/c/coreboot/+/45742/8/src/mainboard/google/voltee...
PS8, Line 18: select EARLY_TCSS_DISPLAY
select EARLY_TCSS_DISPLAY if RUN_FSP_GOP
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45742
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I08c151caa84c1970c77386d9eca156fd3c7f2a12
Gerrit-Change-Number: 45742
Gerrit-PatchSet: 8
Gerrit-Owner: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 13 Nov 2020 20:01:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment