Attention is currently required from: Bob Moragues, David Wu, Eric Lai, Kane Chen, Tarun Tuli.
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75990?usp=email )
Change subject: mb/google/brya: Add support for variant_memcfg_init()
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Sorry, I misunderstood. […]
I think it is better to copy some data than to create a new API for something that can be accomplished without creating new API. You can currently use that approach without requiring any additional support.
I'll ask for additional opinions on this one.
Tarun, what do you think?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75990?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4926139e36602f87c8317ab4b476636e02f87771
Gerrit-Change-Number: 75990
Gerrit-PatchSet: 1
Gerrit-Owner: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Bob Moragues
moragues@google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Attention: Bob Moragues
moragues@google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Fri, 23 Jun 2023 17:46:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: David Wu
david_wu@quanta.corp-partner.google.com
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: comment