Attention is currently required from: Nico Huber, Angel Pons, Arthur Heymans, Kyösti Mälkki. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61215 )
Change subject: device: Add support for PCIe Resizable BARs ......................................................................
Patch Set 3:
(3 comments)
File src/device/Kconfig:
https://review.coreboot.org/c/coreboot/+/61215/comment/5b84ab52_3d265f96 PS3, Line 643: in preference of
NIT - this reads a bit confusing. […]
Done
https://review.coreboot.org/c/coreboot/+/61215/comment/fe614e83_aea7e6b3 PS3, Line 660: )
NIT - end with a period.
Done
File src/device/pci_device.c:
https://review.coreboot.org/c/coreboot/+/61215/comment/3b21c81f_c08e47a0 PS3, Line 351: 4
Should this be assigned a shift value constant like those below (eg. […]
I added a few more comments to what is going on here. Basically there are two bitmasks that are intended to be concatenated together, but they belong to two different registers, therefore this reads them and then shifts them over to where they will form the contiguous bitmask they are supposed to be.