Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42373 )
Change subject: mainboard/hp: Add ProBook 6360b ......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42373/9/src/ec/hp/kbc1126/ec.c File src/ec/hp/kbc1126/ec.c:
https://review.coreboot.org/c/coreboot/+/42373/9/src/ec/hp/kbc1126/ec.c@121 PS9, Line 121: int timeout = 0x17ff; Use decimal notation, and add the unit into the name? Also use `size_t` or `unsigned int`.
https://review.coreboot.org/c/coreboot/+/42373/9/src/ec/hp/kbc1126/ec.c@123 PS9, Line 123: udelay(10); 1. Please use the stopwatch framework, and print out the waited time. 2. A separate commit is indeed better for code outside the mainboard code.