[coreboot-gerrit] Change in coreboot[master]: src/soc/intel/common/itss: Add support to get interrupt table for PCI...

[Aamir Bohra (Code Review)]

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34089 )

Change subject: src/soc/intel/common/itss: Add support to get interrupt table for PCI devices
......................................................................

Patch Set 8:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34089/8/src/soc/intel/common/block/... 
File src/soc/intel/common/block/itss/irq.c:

https://review.coreboot.org/c/coreboot/+/34089/8/src/soc/intel/common/block/... 
PS8, Line 150: while (irq_config) {
             : 		memcpy(dev, &(irq_config->irq), sizeof(struct dev_irq));
             : 		tmp = irq_config;
             : 		irq_config = irq_config->next;
             : 		free(tmp);
             : 		dev++;
             : 		int_dev_entry++;
             : 	}
> Aren't you just passing in pointer to the table in FSP UPD? Then why do you need the memcpy?

Currently ,not passing the pointer, doing a memcpy instead. This how i saw skylake doing it in irq.c. I can try passing the pointer. FSP expects a array for interrupt entries(dev_irq struct) , I would need to memcpy the list data into a static array and pass a pointer then, I believe.