Attention is currently required from: Bora Guvendik, Cliff Huang.
Subrata Banik has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/84392?usp=email )
Change subject: soc/intel/common/block/acpi: Fix GPE1 blocks to ACPI FADT table ......................................................................
Patch Set 4:
(6 comments)
File src/soc/intel/common/block/acpi/Kconfig:
https://review.coreboot.org/c/coreboot/+/84392/comment/cd675dad_74bf8248?usp... : PS4, Line 80: bool "SOC supports GPE1 Event bits" same feedback
https://review.coreboot.org/c/coreboot/+/84392/comment/2713b2f1_c6dbe157?usp... : PS4, Line 88: SOC please change `SOC` to `SoC`
https://review.coreboot.org/c/coreboot/+/84392/comment/92bb36db_074f8ae5?usp... : PS4, Line 94: remove empty lines
https://review.coreboot.org/c/coreboot/+/84392/comment/e941eb5f_f9727dd0?usp... : PS4, Line 96: bool "SOC to use GPE1 Event approach" please don't use the prompt, just `bool` is enough
we need to mention that mainboard should decide if they would like to use the GPE1 where else `SOC_INTEL_COMMON_BLOCK_ACPI_HAVE_GPE1` exposes a SoC capability using ACPI
https://review.coreboot.org/c/coreboot/+/84392/comment/7536e719_7aa5205a?usp... : PS4, Line 99: SOC SoC?
File src/soc/intel/common/block/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/84392/comment/db123944_7a5b8a71?usp... : PS2, Line 111: HAVE
Subra, Yes. […]
Acknowledged