Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44377 )
Change subject: arch/arm: Enable FIT payloads ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44377/4/src/arch/arm/fit_payload.c File src/arch/arm/fit_payload.c:
https://review.coreboot.org/c/coreboot/+/44377/4/src/arch/arm/fit_payload.c@... PS4, Line 17: * effectively unbound. Unlike arm64, arm32 kernels are usually built with a built-in decompressor. That's why using FIT compression doesn't really make sense for them. So I think it's probably fine to just use kernel->size for the amount of space to allocate (like we're already doing for initrd for the same reason), and maybe just return an error if (kernel->compression != CBFS_COMPRESS_NONE).
https://review.coreboot.org/c/coreboot/+/44377/4/src/arch/arm/fit_payload.c@... PS4, Line 72: kernel->offset = 0; Documentation/arm/booting.rst says "It is recommended that it is loaded above 32MiB in order to avoid the need to relocate prior to decompression, which will make the boot process slightly faster." so maybe start this at 32*MiB?