Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31552 )
Change subject: soc/intel/cannonlake: Update GPIO definitions for Virtual GPIO
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31552/1/src/soc/intel/cannonlake/include/soc...
File src/soc/intel/cannonlake/include/soc/gpio_soc_defs.h:
https://review.coreboot.org/#/c/31552/1/src/soc/intel/cannonlake/include/soc...
PS1, Line 200: vGPIO_0
Instead of using vGPIO_{0.. […]
Earlier we set it as RSVD since vGPIO had not been listed into PCH EDS, but if that's already in kernel, I will also vote for follow kernel naming.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31552
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4da161b91f83749b0ae29b387b5c99c1c3f706d8
Gerrit-Change-Number: 31552
Gerrit-PatchSet: 1
Gerrit-Owner: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 21 Feb 2019 19:03:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment