Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46250 )
Change subject: soc/intel/cannonlake: Improve memcfg comments ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46250/1/src/soc/intel/cannonlake/in... File src/soc/intel/cannonlake/include/soc/cnl_memcfg_init.h:
https://review.coreboot.org/c/coreboot/+/46250/1/src/soc/intel/cannonlake/in... PS1, Line 102: or left blank
Good point. I can try and see what happens.
fsp only has defaults for some SKUs and this even depends on which fsp base code was used (the older, platform-based code or the newer "onesilicon" based code like CML,ICL,TGL). Since this doesn't seem to be stable enough, let's drop "or left blank". What do you think?