Attention is currently required from: Jason Glenesk, Martin Roth, Furquan Shaikh, Marshall Dawson, Karthik Ramasubramanian, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56885 )
Change subject: mb/(amd,google): Update SPI Kconfig settings based on devicetree
......................................................................
Patch Set 5:
(3 comments)
File src/mainboard/google/guybrush/Kconfig:
https://review.coreboot.org/c/coreboot/+/56885/comment/a9e413d9_04975aeb
PS5, Line 107: ALT_SPI_SPEED
When is the ALT used?
https://review.coreboot.org/c/coreboot/+/56885/comment/1acabd1d_6f5f8853
PS5, Line 110: config TPM_SPI_SPEED
: default 0 # 66MHz
:
Can we remove this since we don't use the TPM SPI interface on guybrush/zork?
File src/mainboard/google/zork/Kconfig:
https://review.coreboot.org/c/coreboot/+/56885/comment/e3b0d968_058035d5
PS5, Line 250: 4
Can you split this out into its own CL. Curious what the boot time improvement is, if any...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56885
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icce1d57761465ae8255e5d9ce8679f3fdcb0ceed
Gerrit-Change-Number: 56885
Gerrit-PatchSet: 5
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 16 Aug 2021 21:44:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment