Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35766 )
Change subject: mediatek/mt8183: Pass impedance data as a function argument ......................................................................
Patch Set 1: Code-Review+1
(3 comments)
just some nits, being good in general.
https://review.coreboot.org/c/coreboot/+/35766/1/src/soc/mediatek/mt8183/dra... File src/soc/mediatek/mt8183/dramc_init_setting.c:
https://review.coreboot.org/c/coreboot/+/35766/1/src/soc/mediatek/mt8183/dra... PS1, Line 952: struct dram_impedance *impedance) indent properly
https://review.coreboot.org/c/coreboot/+/35766/1/src/soc/mediatek/mt8183/dra... File src/soc/mediatek/mt8183/dramc_pi_basic_api.c:
https://review.coreboot.org/c/coreboot/+/35766/1/src/soc/mediatek/mt8183/dra... PS1, Line 151: struct dram_impedance *impedance) indent properly?
https://review.coreboot.org/c/coreboot/+/35766/1/src/soc/mediatek/mt8183/inc... File src/soc/mediatek/mt8183/include/soc/dramc_pi_api.h:
https://review.coreboot.org/c/coreboot/+/35766/1/src/soc/mediatek/mt8183/inc... PS1, Line 109: struct dram_impedance *impedance); indent properly?