Attention is currently required from: Arthur Heymans, Christian Walter, Eric Lai, Felix Singer, Lean Sheng Tan, Nico Huber, Patrick Rudolph, Paul Menzel, Tim Chu.
Ziang Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75740?usp=email )
Change subject: soc/intel/xeon_sp/spr: Fix memory max capacity per processor
......................................................................
Patch Set 7:
(1 comment)
File src/soc/intel/xeon_sp/spr/romstage.c:
https://review.coreboot.org/c/coreboot/+/75740/comment/2bb3b18c_94c02a5c :
PS1, Line 277: * Persistent Memory 300 Series mapped as memory) per Socket
Thanks. So 3DS isn't part of the calculation, I guess. Can one have max. DRAM
and max. Optane at once? If not, isn't it like `MAX(MAX_DRAM, MAX_OPTANE)`?
So 4GiB?
Yes, one can have both (so 6TB), it is clarified in SPR spec.
Then give it a meaning macro name instead 6 would be better. Like max_support_unit or something.
Done.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75740?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieb892d3b148291b35808d634d63b58b90d456767
Gerrit-Change-Number: 75740
Gerrit-PatchSet: 7
Gerrit-Owner: Ziang Wang
ziang.wang@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Mon, 12 Jun 2023 10:30:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Ziang Wang
ziang.wang@intel.com
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment