Attention is currently required from: Shelley Chen, Ravi kumar, Sudheer Amrabadi. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57449 )
Change subject: Herobrine: sc7280: Add support for audio ......................................................................
Patch Set 29:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57449/comment/2c648bae_43830156 PS29, Line 7: Herobrine mb/google/herobrine
https://review.coreboot.org/c/coreboot/+/57449/comment/12624b1e_2f56c92f PS29, Line 7: sc7280: Not needed.
https://review.coreboot.org/c/coreboot/+/57449/comment/cb7f9daa_22b83bed PS29, Line 7: Herobrine: sc7280: Add support for audio … and TPM?
https://review.coreboot.org/c/coreboot/+/57449/comment/8c6bd4d1_393e6a23 PS29, Line 9: gpio GPIO
https://review.coreboot.org/c/coreboot/+/57449/comment/9db17b33_b24d54ed PS29, Line 9: Add gpio configuration for target specific i2s ports 1. Please add a dot/period at the end of the line. 2. Please mention the source. Schematics?
File src/mainboard/google/herobrine/mainboard.c:
https://review.coreboot.org/c/coreboot/+/57449/comment/cd350c5f_2cf66bc1 PS28, Line 43: No blank line needed.