Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25372 )
Change subject: sdm845: Add QUPv3 FW load & config
......................................................................
Patch Set 73:
(1 comment)
https://review.coreboot.org/#/c/25372/6/src/mainboard/google/cheza/qupv3_con...
File src/mainboard/google/cheza/qupv3_config.c:
https://review.coreboot.org/#/c/25372/6/src/mainboard/google/cheza/qupv3_con...
PS6, Line 18: struct se_cfg se_mappings[QUPV3_SE_MAX] =
To load QUPV3 firmware from respective driver init function […]
I don't understand this explanation, can you please clarify? What registers are you talking about? Which sequence is fixed -- do you mean the order the QUPs get initialized in? Why? Aren't they all independent?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/25372
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6e87f868ecbe2a8e51d94c045ad76b99bb1b345d
Gerrit-Change-Number: 25372
Gerrit-PatchSet: 73
Gerrit-Owner: mturney mturney
mturney@codeaurora.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Mukesh Savaliya
msavaliy@qualcomm.corp-partner.google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Akash Asthana
akashast@qualcomm.corp-partner.google.com
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Thu, 13 Jun 2019 02:30:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Akash Asthana
akashast@qualcomm.corp-partner.google.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment