Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31710 )
Change subject: drivers/spi: Move M25Pxx commands to spi_winbond.h
......................................................................
Patch Set 5:
(3 comments)
Update the comment
https://review.coreboot.org/#/c/31710/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31710/1//COMMIT_MSG@9
PS1, Line 9:
Just one space.
Done
https://review.coreboot.org/#/c/31710/1//COMMIT_MSG@9
PS1, Line 9: Move Wnbond M25PXX command values to spi_winbond.h
Dot/period at the end please.
Done
https://review.coreboot.org/#/c/31710/1//COMMIT_MSG@11
PS1, Line 11: including
include?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31710
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9c17c4ed7004209bd3c619d47a7474b0b7e17495
Gerrit-Change-Number: 31710
Gerrit-PatchSet: 5
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 03 Apr 2019 13:24:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment