Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40430 )
Change subject: src/soc/{mediatek,nvidia}: Drop duplicated branches
......................................................................
Patch Set 3:
(1 comment)
I’d be great to have two commits.
https://review.coreboot.org/c/coreboot/+/40430/3/src/soc/nvidia/tegra124/sor...
File src/soc/nvidia/tegra124/sor.c:
https://review.coreboot.org/c/coreboot/+/40430/3/src/soc/nvidia/tegra124/sor...
PS3, Line 253: /* FIXME: reg_val |= (0 << 23) and reg_val &= ~(0 <<23) will change nothing */
Should it be `(1 << 23)`?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40430
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I30af5191b924666f29b8fcfc7a7478a50e5a6084
Gerrit-Change-Number: 40430
Gerrit-PatchSet: 3
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 16 Apr 2020 12:33:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment