[coreboot-gerrit] [XL] Change in coreboot[main]: mb/lattepanda: Add support for LattePanda Mu

[Felix Held (Code Review)]

Attention is currently required from: KunYi Chen, Nicholas Chin, Nicholas Sudsgaard, Paul Menzel.

Felix Held has posted comments on this change by KunYi Chen. ( https://review.coreboot.org/c/coreboot/+/83719?usp=email )

Change subject: mb/lattepanda: Add support for LattePanda Mu
......................................................................

Patch Set 27: Code-Review+2

(2 comments)

Patchset:

PS27: 
i'd say that the patch is in a reasonable shape to be submitted into upstream and the remaining things can be addressed in follow-up patches

File src/mainboard/lattepanda/mu/bootblock.c:

https://review.coreboot.org/c/coreboot/+/83719/comment/d5177c53_e9ca1a6a?usp... :
PS27, Line 29: static const struct initdata init_values[] = {
hmm, we do have native code for most of the things done via this table; also most if not all of the things not needed to be done in bootblock can be done via devicetree entries and a proper driver for that super i/o chip. i'll mark this as resolved to get the board upstream, but would still be good if you could look into this