Attention is currently required from: Richard Hughes, Nicholas Chin.
Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68995 )
Change subject: Documentation/sbom: Add SBOM Documentation ......................................................................
Patch Set 4:
(13 comments)
File Documentation/sbom/sbom.md:
PS3:
Please reflow all lines to 72 characters
Done
https://review.coreboot.org/c/coreboot/+/68995/comment/eac9fc45_a75784d2 PS3, Line 2: One could for example create a Software that takes a Coreboot Firmware Image as Input and automatically creates a Graph with all Software components the Coreboot Image contains and their relationship to each other
Is there a reason why many words like "Software", "Information", "Binary" and others need to be capi […]
Done
https://review.coreboot.org/c/coreboot/+/68995/comment/7b64b73d_59d8480b PS3, Line 2: Coreboot
coreboot
Done
https://review.coreboot.org/c/coreboot/+/68995/comment/081554b0_5fa5ba2a PS3, Line 2: Coreboot
coreboot
Done
https://review.coreboot.org/c/coreboot/+/68995/comment/054e8b14_e90bafd6 PS3, Line 2: shipped
Maybe "included" or "pulled in", as "shipped" could imply that the coreboot distributes FSP, which w […]
Done
https://review.coreboot.org/c/coreboot/+/68995/comment/585ab872_e74ca2c6 PS3, Line 2: would be
Maybe "were a"
Done
https://review.coreboot.org/c/coreboot/+/68995/comment/5b7680ae_17eeee37 PS3, Line 2: These
I think "This" works better here
Done
https://review.coreboot.org/c/coreboot/+/68995/comment/046de678_f58190fa PS3, Line 17: ]
Should be ) to match opening (
Done
https://review.coreboot.org/c/coreboot/+/68995/comment/57d2d260_1b26e580 PS3, Line 18: CONFIG_[software-name]_SBOM_GENEREATE
This config appears to be CONFIG_SBOM_[software-name]_GENERATE in the actual Kconfigs
Done
https://review.coreboot.org/c/coreboot/+/68995/comment/e8a23ac6_f69870d7 PS3, Line 18: GENEREATE
GENERATE
Done
https://review.coreboot.org/c/coreboot/+/68995/comment/84b7bd4e_4e92ea8e PS3, Line 19: CONFIG_[software-name]_SBOM_PATH
This config appears to be CONFIG_SBOM_[software-name]_PATH, which was also the order used in previou […]
Done
https://review.coreboot.org/c/coreboot/+/68995/comment/e1ae5c19_4f17ae7e PS3, Line 22: Just enable the corresponding options in `make menuconfig`
Maybe specify under which submenu these are under?
Done
File Documentation/sbom/sbom_generation.png:
PS3:
Images should be kept small. They should be under 700px in width, as the current theme doesn't allow bigger images.
Does that limitation still apply? Most of the Images in coreboot documentation are actually bigger