build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46282 )
Change subject: nb/intel/pineview: Get rid of MCHBARxx_{AND_OR,AND,OR} macros ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/c/coreboot/+/46282/4/src/northbridge/intel/pinev... File src/northbridge/intel/pineview/raminit.c:
https://review.coreboot.org/c/coreboot/+/46282/4/src/northbridge/intel/pinev... PS4, Line 937: mchbar32_unset_and_set(C0DQSDQRyTX3(rank), (1 << (dqs * 2 + 17)) | (1 << (dqs * 2 + 16)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/46282/4/src/northbridge/intel/pinev... PS4, Line 1361: mchbar8_unset_and_set(C0DCOMPx(i), 0x03, rcompdelay2[s->dimm_config[0]]); line over 96 characters
https://review.coreboot.org/c/coreboot/+/46282/4/src/northbridge/intel/pinev... PS4, Line 1458: mchbar8_unset_and_set(C0SLEWPULUTx(2) + i, 0x3f, rcomplut[j][10]); line over 96 characters
https://review.coreboot.org/c/coreboot/+/46282/4/src/northbridge/intel/pinev... PS4, Line 1479: mchbar8_unset_and_set(C0SLEWPDLUTx(2) + i, 0x3f, rcomplut[j][11]); line over 96 characters