[coreboot-gerrit] Change in coreboot[master]: soc/intel/tigerlake: Configure TCSS D3Cold for pre-QS and QS platforms

[Caveh Jalali (Code Review)]

Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43980 )

Change subject: soc/intel/tigerlake: Configure TCSS D3Cold for pre-QS and QS platforms
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43980/3/src/soc/intel/tigerlake/fsp... 
File src/soc/intel/tigerlake/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/43980/3/src/soc/intel/tigerlake/fsp... 
PS3, Line 123: TcssD3ColdEnable
> I mean we need to remove all TcssD3ColdEnable across both of Volteer and TGLRVP first. […]

i think it's reasonable to include the 1-line edits to the 3 devicetree.cb
files with this patch for consistency. the only change in the device trees
will be to remove the TcssD3ColdEnable lines since they'll become redundant.

the beauty is that we can eliminate the TcssD3ColdEnable line from all
device trees unless there are exceptional circumstances.