Ivan Vatlin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38143 )
Change subject: mb/asus/p5qc: Add ASUS P5Q as a variant (with documentation) ......................................................................
Patch Set 18:
(8 comments)
https://review.coreboot.org/c/coreboot/+/38143/18/Documentation/mainboard/as... File Documentation/mainboard/asus/p5q.md:
https://review.coreboot.org/c/coreboot/+/38143/18/Documentation/mainboard/as... PS18, Line 66: model f4x, f6x, 6fx, 1067x (pentium 4, d, core 2)
Nit: use capitals for names […]
Ack
https://review.coreboot.org/c/coreboot/+/38143/18/src/mainboard/asus/p5qc/va... File src/mainboard/asus/p5qc/variants/p5q/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38143/18/src/mainboard/asus/p5qc/va... PS18, Line 50: PCIe 1 slot 1
State: on […]
Ack
https://review.coreboot.org/c/coreboot/+/38143/18/src/mainboard/asus/p5qc/va... PS18, Line 51: PCIe 2 slot 2
State: on […]
Ack
https://review.coreboot.org/c/coreboot/+/38143/18/src/mainboard/asus/p5qc/va... PS18, Line 52: PCIe 3 slot 3
State: off […]
Ack
https://review.coreboot.org/c/coreboot/+/38143/18/src/mainboard/asus/p5qc/va... PS18, Line 53: PCIe 4 (Silicon Image?)
State: off […]
Ack
https://review.coreboot.org/c/coreboot/+/38143/18/src/mainboard/asus/p5qc/va... PS18, Line 54: PCIe 5 MARVELL IDE
State: on […]
Ack
https://review.coreboot.org/c/coreboot/+/38143/18/src/mainboard/asus/p5qc/va... PS18, Line 55: PCIe 6 ethernet NIC
State: on […]
Ack
https://review.coreboot.org/c/coreboot/+/38143/18/src/mainboard/asus/p5qc/va... PS18, Line 89: irq 0xe5 = 0x02 #Need to test with 0x82 value
You can drop this line entirely. Register 0xe4 is setting all GPIOs as input except for GPIO82. […]
Ack