Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/58224 )
Change subject: soc/amd/common/block/include/psp_efs: use unsigned type for bitfield ......................................................................
soc/amd/common/block/include/psp_efs: use unsigned type for bitfield
For 1 bit long bitfields an unsigned type should be used.
TEST=Resulting image of a timeless build for google/guybrush results in identical binary.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: Ic630d1709174d90336746bc37da504437c12643c --- M src/soc/amd/common/block/include/amdblocks/psp_efs.h 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/58224/1
diff --git a/src/soc/amd/common/block/include/amdblocks/psp_efs.h b/src/soc/amd/common/block/include/amdblocks/psp_efs.h index 7afd295..77da70a 100644 --- a/src/soc/amd/common/block/include/amdblocks/psp_efs.h +++ b/src/soc/amd/common/block/include/amdblocks/psp_efs.h @@ -26,8 +26,8 @@
struct second_gen_efs { /* todo: expand for Server products */ - int gen:1; /* Client products only use bit 0 */ - int reserved:31; + uint32_t gen:1; /* Client products only use bit 0 */ + uint32_t reserved:31; } __attribute__((packed));
/* Copied from coreboot/util/amdfwtool.h */