Nick Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45860 )
Change subject: mb/google/volteer: Add a DPTF policy for Eldrid
......................................................................
Patch Set 21:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45860/18/src/mainboard/google/volte...
File src/mainboard/google/volteer/variants/eldrid/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45860/18/src/mainboard/google/volte...
PS18, Line 69: 3
Are you trying to just override the thresholds for CPU and sensor 2? Then you'll need the following: […]
Done
https://review.coreboot.org/c/coreboot/+/45860/18/src/mainboard/google/volte...
PS18, Line 74: 3
Same as above, if you're trying to overwrite/override the settings for CPU & temp_sensor_2, you'll n […]
Done
https://review.coreboot.org/c/coreboot/+/45860/18/src/mainboard/google/volte...
PS18, Line 79:
To disable active policy, you'll need the following: […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45860
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I99e429b90ed7de08385fe51ca742865b1266eef9
Gerrit-Change-Number: 45860
Gerrit-PatchSet: 21
Gerrit-Owner: Nick Chen
nick_xr_chen@wistron.corp-partner.google.com
Gerrit-Reviewer: Keith Short
keithshort@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anfernee Chen
anfernee_chen@wistron.corp-partner.google.com
Gerrit-CC: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-CC: Keith Short
keithshort@chromium.org
Gerrit-CC: Malik Hsu
malik_hsu@wistron.corp-partner.google.com
Gerrit-CC: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-CC: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-CC: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-Comment-Date: Thu, 15 Oct 2020 02:26:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment