Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42551 )
Change subject: hatch: Create wyvern variant ......................................................................
Patch Set 1: Code-Review-2
Patch Set 1:
Patch Set 1:
(4 comments)
Hey Paul, thanks for the patch. Please see inline comments. I think there is a few not too bad bugs here however could you raise them from review and assign them to me please.
All of this code comes from the templates, see util/mainboard/google/puff/template. That's where we'll need to make any source code changes for future variants.
OK, however I think we should address some key issues here like puff variants not using hardcoded spd data. Then regenerate this patch, otherwise we are essentially merging an unbootable board into coreboot.