build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37872 )
Change subject: biostar/a68n_5200: Switch away from ROMCC_BOOTBLOCK
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37872/6/src/mainboard/biostar/a68n_...
File src/mainboard/biostar/a68n_5200/bootblock.c:
https://review.coreboot.org/c/coreboot/+/37872/6/src/mainboard/biostar/a68n_...
PS6, Line 21: #define SB_MMIO_MISC32(x) *(volatile u32 *)(AMD_SB_ACPI_MMIO_ADDR + 0xE00 + (x))
Macros with complex values should be enclosed in parentheses
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37872
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2e710ac61843c09a055523c7971e4c05bae56a37
Gerrit-Change-Number: 37872
Gerrit-PatchSet: 6
Gerrit-Owner: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 31 Dec 2019 07:59:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment