Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Paul Menzel.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60002 )
Change subject: mb/google/corsola: set up open-drain ChromeOS pins
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/corsola/chromeos.c:
https://review.coreboot.org/c/coreboot/+/60002/comment/9570eb0f_b99c0171
PS4, Line 29: GPO
GPO os GPIO?
GPO or GPIO?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60002
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib55a773bb63404a1b952f7e7645eb7aba6638b00
Gerrit-Change-Number: 60002
Gerrit-PatchSet: 4
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Mon, 13 Dec 2021 06:16:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment