12 Mar
2021
12 Mar
'21
9:37 p.m.
Attention is currently required from: Angel Pons. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51417 )
Change subject: device/pciexp_device.c: Remove CPP guarding ......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51417/comment/b03564ae_9f370a2f PS3, Line 10: This fixes building with !CONFIG_PCIEXP_HOTPLUG on some platforms.
Then I wonder why someone complained on IRC about build failures on bd82x6x...
Both codepaths are now buildtested with this CL although not in combination with bd82x6x, but there isn't something special about that combination after this change.
--
To view, visit https://review.coreboot.org/c/coreboot/+/51417
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I46560722dcb5f1d902709e40b714ef092515b164
Gerrit-Change-Number: 51417
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 12 Mar 2021 10:37:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz
Gerrit-MessageType: comment