Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36321 )
Change subject: arch/x86/*.S: use defines instead of hardcoded values
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36321/1/src/arch/x86/include/arch/r...
File src/arch/x86/include/arch/ram_segs.h:
https://review.coreboot.org/c/coreboot/+/36321/1/src/arch/x86/include/arch/r...
PS1, Line 17: #define RAM_CODE_SEG 0x10
Can/Should we use these in the gdt itself? I guess it's a little hard in the current form where it's […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36321
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib006cd4df59951335506b8153e9347450ec3403e
Gerrit-Change-Number: 36321
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 29 Oct 2019 19:40:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment