Attention is currently required from: Angel Pons, Arthur Heymans, Patrick Rudolph, Shuo Liu.
yuchi.chen@intel.com has posted comments on this change by Shuo Liu. ( https://review.coreboot.org/c/coreboot/+/85283?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: soc/intel/common/block: Add const qualifier for input of pirq ops
......................................................................
Patch Set 5:
(1 comment)
File src/soc/intel/common/block/include/intelblocks/itss.h:
https://review.coreboot.org/c/coreboot/+/85283/comment/2ba914db_6f78ccae?usp... :
PS5, Line 51: uint32_t itss_soc_get_on_chip_dev_pir(const struct device *dev);
Snow Ridge is also using this function, I'm wondering why compiler doesn't complain about this inconsistency.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85283?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I65b4de3f51b109bfcabfaa0ebe47a22bdd69d1a0
Gerrit-Change-Number: 85283
Gerrit-PatchSet: 5
Gerrit-Owner: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: yuchi.chen@intel.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Sun, 08 Dec 2024 23:58:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No